Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more code style requirements #456

Closed
wants to merge 3 commits into from
Closed

Conversation

Susurrus
Copy link
Contributor

Writes down a few of the things we've discussed on gitter.

@Susurrus Susurrus force-pushed the contributing branch 2 times, most recently from 5b1dd49 to 4c58c31 Compare June 3, 2017 15:59
@Susurrus
Copy link
Contributor Author

Susurrus commented Jun 3, 2017

Updated based on comments by @retep998 in #447.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jun 3, 2017

Also added line wrapping so it's easier to read and edit in a termianl.

@retep998
Copy link
Owner

Conflicts.

@Susurrus
Copy link
Contributor Author

Should be fixed now.

@Susurrus
Copy link
Contributor Author

@retep998 This should be all clear to merge. Just wanted to ping you on this since it's a minor PR that should help contributors on future PRs.

@Susurrus
Copy link
Contributor Author

Looks like you manually added a lot of stuff that this covered here, so it's no longer necessary.

@Susurrus Susurrus closed this Jul 25, 2017
@Susurrus Susurrus deleted the contributing branch July 25, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants